release: prepare 1.1.0 validation - #333
Merged
Merged
Conversation
Member
Author
|
@claude do a pass |
|
Claude finished @Mattsface's task in 2m 37s —— View job Review completeTodo list
SummaryThis is a well-scoped, additive release-prep PR — no runtime behavior changes, purely docs + version bump + release-validation tooling. I diffed against
No correctness issues found. Two minor, non-blocking observations:
Nice to have but not required: this PR doesn't touch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Prepare
python-mlb-statsapi1.1.0 for final release validation under #307.The release branch already contains the implementation work for 1.1.0, including the new async API. This PR finishes the release-preparation layer: it updates package/version documentation for 1.1.0 and strengthens release validation so the built wheel and source distribution are verified for both sync-only and
[async]installations.The goal is to make sure the artifacts we publish match the documented 1.1.0 public contract without changing existing synchronous runtime behavior.
What
1.0.1to1.1.0docs/releases/1.1.0.mdscripts/validate_release.pyso both the wheel and sdist are tested in clean environments for:[async]extraAsyncMlbandAsyncMlbDataAdapterroot importsstrict_http=Truedefault behaviorstrict_http=False1.x compatibility behaviorThis PR does not redesign the async implementation, change dependency architecture, or intentionally change the existing synchronous public API.
Tests
GitHub Actions passes on the branch:
The build validation also successfully:
scripts/validate_release.pyAll artifact smoke validation remains offline and does not contact the live MLB API.
Risk and impact
Risk level: Normal
The package runtime implementation is not being changed here, which limits direct regression risk for users. However, this PR makes a substantial change to the release-validation tooling and expands the checks applied to the actual wheel and source distribution, so it is more than a documentation-only or minimal-risk release bump.
If something goes wrong with this PR, the primary impact would be to the release process rather than normal library runtime behavior. A validation bug could incorrectly reject a valid 1.1.0 artifact or, more importantly, fail to catch a packaging problem before publication.
The most important compatibility requirement remains unchanged: existing 1.0.x synchronous users should require no code changes when upgrading to 1.1.0.
Closes #307