[PWGUD] Adding bc-by-bc trigger info and getting info from DB#17058
Open
jgcn wants to merge 3 commits into
Open
[PWGUD] Adding bc-by-bc trigger info and getting info from DB#17058jgcn wants to merge 3 commits into
jgcn wants to merge 3 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 6d6f50c at 2026-07-14 14:39: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 6d6f50c at 2026-07-14 14:42: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 6d6f50c at 2026-07-14 14:48: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for aebc723 at 2026-07-15 14:56: Full log here. |
vkucera
requested changes
Jul 15, 2026
vkucera
reviewed
Jul 15, 2026
|
|
||
| // fill output table | ||
| int recoFlag = (col.flags() & dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? 1 : 0; | ||
| int recoFlag = static_cast<int>((col.flags() & dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? true : false); |
Collaborator
There was a problem hiding this comment.
This is wrong. You are converting int -> bool on the left side of ? and converting bool -> int on the right side.
You can simply use TESTBIT(col.flags(), dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? 1 : 0.
Collaborator
There was a problem hiding this comment.
Also, what do 1 and 0 mean?
Collaborator
Author
There was a problem hiding this comment.
Hi
thanks for the tip, and for the email explanations. I will try to follow as much as I can, and push again. I know that C++ is my tool and as such part of my job, but my real job is something else, so the learning curve for me takes a long time to travel ... I am trying, hopefully my learning will converge somewhen ... I will try to push this and whatever I understand from the email tomorrow. Thanks a lot for your help.
guillermo
Collaborator
|
Error while checking build/O2Physics/code-check for 71a83e7 at 2026-07-15 18:36: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes:
get ITS ROF info from database instead of having it hardwired
add info on bc-by.bc triggers
Minor changes:
better definition of TF axis