Skip to content

[PWGUD] Adding bc-by-bc trigger info and getting info from DB #17058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgcn wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[PWGUD] Adding bc-by-bc trigger info and getting info from DB #17058

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d6f50c
Adding bc by bc trigger info and getting info from DB
Jul 14, 2026
aebc723
Right include path, deleting trailing spaces and some tabs
Jul 15, 2026
71a83e7
Small changes according to results of checks and from Vit's request
Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 56 additions & 16 deletions PWGUD/Tasks/upcVmRof.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <CommonDataFormat/TimeStamp.h>
#include <DataFormatsParameters/AggregatedRunInfo.h>
#include <DataFormatsParameters/GRPLHCIFData.h>
#include <DataFormatsITSMFT/DPLAlpideParam.h>
#include <Framework/ASoA.h>
#include <Framework/AnalysisDataModel.h>
#include <Framework/AnalysisHelpers.h>
Expand Down Expand Up @@ -164,7 +165,7 @@ struct UpcVmRof {
Produces<o2::aod::FourTrkTable> fourTrkTable;

// services
Service<o2::ccdb::BasicCCDBManager> ccdb; // access to database
Service<o2::ccdb::BasicCCDBManager> ccdb{}; // access to database

// histograms
HistogramRegistry bcTH1Registry{"bcTH1Registry", {}};
Expand All @@ -180,10 +181,13 @@ struct UpcVmRof {
std::bitset<o2::constants::lhc::LHCMaxBunches> bcPatternA;
std::bitset<o2::constants::lhc::LHCMaxBunches> bcPatternB;
std::bitset<o2::constants::lhc::LHCMaxBunches> bcPatternC;
std::vector<int> bcbIdx;
int nbcB = 0;

// constants related to ITS ROFs
static constexpr int RofPerOrbit = 6; // valid for pO, OO and PbPb in Run 3
static constexpr int RofShift = 64; // bc shift of ITS. Valid for pO, OO and PbPb in Run 3
// variables to store ITS ROF info
int rofPerOrbit = -1; // number of rofs per orbit
int rofLength = -1; // number of bcs per ROF
int rofShift = -1; // bc shift of ITS.

// variables to store run info
int runNumberBc = 0; // run number used to process BCs
Expand All @@ -192,7 +196,6 @@ struct UpcVmRof {
int64_t orbitsPerTF = 0; // number of orbits per TF
int64_t bcSOR = 0; // first bc of the first orbit
int64_t nBCsPerTF = 0; // duration of TF in bcs
int64_t nBCsPerROF = 0; // number of bcs per ROF
int64_t currentTF = -1; // current time frame being looked at
int64_t nTF = 0; // number of time frames in run

Expand All @@ -216,16 +219,40 @@ struct UpcVmRof {
Configurable<float> maxTrkDcaZ{"maxTrkDcaZ", 2.0, "max DCA in z of track to vtx (cm)"};
Configurable<int> tfPerBin{"tfPerBin", 10000, "timeframes per bin 1e4 means some 28 s"};



//--------------------------------------------------------------------------------
// get ITS ROF info
// code from https://github.com/AliceO2Group/O2Physics/blob/master/Common/Tools/EventSelectionModule.h#L779-L780
void getRofInfo()
{
auto alppar = ccdb->getForTimeStamp<o2::itsmft::DPLAlpideParam<0>>("ITS/Config/AlpideParam", sor);
rofShift = alppar->roFrameBiasInBC;
rofLength = alppar->roFrameLengthInBC;
rofPerOrbit = static_cast<int>(o2::constants::lhc::LHCMaxBunches/rofLength);
}

//--------------------------------------------------------------------------------
// get filling scheme
void getFillingScheme()
{
// get the info
auto grplhcif = ccdb->getForTimeStamp<o2::parameters::GRPLHCIFData>("GLO/Config/GRPLHCIF", sor);
beamPatternA = grplhcif->getBunchFilling().getBeamPattern(0);
beamPatternC = grplhcif->getBunchFilling().getBeamPattern(1);
bcPatternA = beamPatternA & ~beamPatternC;
bcPatternB = beamPatternA & beamPatternC;
bcPatternC = ~beamPatternA & beamPatternC;
// define internal indices to access the correct bin in histogram
bcbIdx.clear();
nbcB = 0;
for (int i = 0; i < o2::constants::lhc::LHCMaxBunches; i++) {
bcbIdx.push_back(-1);
if (bcPatternB.test(i)) {
bcbIdx[i] = nbcB;
nbcB++;
}
}
} // end getFillingScheme()

//--------------------------------------------------------------------------------
Expand Down Expand Up @@ -254,7 +281,6 @@ struct UpcVmRof {
auto orbitSOR = runInfo.orbitSOR;
auto orbitEOR = runInfo.orbitEOR;
orbitsPerTF = runInfo.orbitsPerTF;
nBCsPerROF = o2::constants::lhc::LHCMaxBunches / RofPerOrbit;
bcSOR = orbitSOR * o2::constants::lhc::LHCMaxBunches; // first bc of the first orbit
nBCsPerTF = orbitsPerTF * o2::constants::lhc::LHCMaxBunches; // duration of TF in bcs
nTF = std::ceil((orbitEOR - orbitSOR) / orbitsPerTF);
Expand All @@ -278,12 +304,13 @@ struct UpcVmRof {
// compute ROF for this BC
int getRof(int64_t thisBC)
{
int64_t bctmp = thisBC - RofShift;
int64_t bctmp = thisBC - rofShift;
if (bctmp < 0)
bctmp = o2::constants::lhc::LHCMaxBunches - RofShift - 1;
return static_cast<int>(bctmp / nBCsPerROF);
bctmp = o2::constants::lhc::LHCMaxBunches - rofShift - 1;
return static_cast<int>(bctmp / rofLength);
}


//--------------------------------------------------------------------------------
// check flags for a bc
bool checkBcFlags(const auto& bc, int run)
Expand Down Expand Up @@ -339,15 +366,24 @@ struct UpcVmRof {
bcTH1Pointers[Form("bc/%d/bcPatternC_H", run)] = bcTH1Registry.add<TH1>(Form("bc/%d/bcPatternC_H", run), "Pattern of bc-C; bcID;",
{HistType::kTH1D, {{o2::constants::lhc::LHCMaxBunches, -0.5, static_cast<double>(o2::constants::lhc::LHCMaxBunches) - 0.5}}});

// trigger info
// bc sel and tf info
int nBinsTF = static_cast<int>(nTF/tfPerBin)+1;
int lastTFinHisto = (nBinsTF*tfPerBin)-1; // first TF is zero
bcTH1Pointers[Form("bc/%d/bcSel_H", run)] = bcTH1Registry.add<TH1>(Form("bc/%d/bcSel_H", run), "bc selection counter; selID; Counter",
{HistType::kTH1D, {{4, -0.5, 3.5}}});
bcTH1Pointers[Form("bc/%d/tf_H", run)] = bcTH1Registry.add<TH1>(Form("bc/%d/tf_H", run), "analysed time frames;TF;Counts",
{HistType::kTH1D, {{static_cast<int>(nTF / tfPerBin), -0.5, static_cast<double>(nTF) - 0.5}}});
{HistType::kTH1D, {{nBinsTF, -0.5, static_cast<double>(lastTFinHisto) - 0.5}}});
// trigger info per rof
bcTH2Pointers[Form("bc/%d/ft0Vtx_H", run)] = bcTH2Registry.add<TH2>(Form("bc/%d/ft0Vtx_H", run), "ft0Vtx triggers; TF; ROF; Counter",
{HistType::kTH2F, {{static_cast<int>(nTF / tfPerBin), -0.5, static_cast<double>(nTF) - 0.5}, {RofPerOrbit, -0.5, RofPerOrbit - 0.5}}});
{HistType::kTH2F, {{nBinsTF, -0.5, static_cast<double>(lastTFinHisto) - 0.5}, {rofPerOrbit, -0.5, rofPerOrbit - 0.5}}});
bcTH2Pointers[Form("bc/%d/ft0VtxCe_H", run)] = bcTH2Registry.add<TH2>(Form("bc/%d/ft0VtxCe_H", run), "ft0VtxCe triggers; TF; ROF; Counter",
{HistType::kTH2F, {{static_cast<int>(nTF / tfPerBin), -0.5, static_cast<double>(nTF) - 0.5}, {RofPerOrbit, -0.5, RofPerOrbit - 0.5}}});
{HistType::kTH2F, {{nBinsTF, -0.5, static_cast<double>(lastTFinHisto) - 0.5}, {rofPerOrbit, -0.5, rofPerOrbit - 0.5}}});
// trigger info per bcb
bcTH2Pointers[Form("bc/%d/ft0Vtx_bcb_H", run)] = bcTH2Registry.add<TH2>(Form("bc/%d/ft0Vtx_bcb_H", run), "ft0Vtx triggers; TF; bc-B idx; Counter",
{HistType::kTH2F, {{nBinsTF, -0.5, static_cast<double>(lastTFinHisto) - 0.5}, {nbcB, -0.5, nbcB - 0.5}}});
bcTH2Pointers[Form("bc/%d/ft0VtxCe_bcb_H", run)] = bcTH2Registry.add<TH2>(Form("bc/%d/ft0VtxCe_bcb_H", run), "ft0Vtx triggers; TF; bc-B idx; Counter",
{HistType::kTH2F, {{nBinsTF, -0.5, static_cast<double>(lastTFinHisto) - 0.5}, {nbcB, -0.5, nbcB - 0.5}}});


} // addBcHistos

Expand Down Expand Up @@ -415,8 +451,9 @@ struct UpcVmRof {
if (runNumberBc != bcAt0.runNumber()) { // new run
runNumberBc = bcAt0.runNumber();
getRunInfo(runNumberBc);
addBcHistos(runNumberBc);
getFillingScheme();
getRofInfo();
addBcHistos(runNumberBc);
fillBcPatternHistos(runNumberBc);
}

Expand Down Expand Up @@ -448,8 +485,11 @@ struct UpcVmRof {
bool ft0ceTrg = mask[Ft0CeIdx];
if (ft0vtxTrg) {
bcTH2Pointers[Form("bc/%d/ft0Vtx_H", runNumberBc)]->Fill(thisTF, thisROF);
if (ft0ceTrg)
bcTH2Pointers[Form("bc/%d/ft0Vtx_bcb_H", runNumberBc)]->Fill(thisTF, bcbIdx[thisBC]);
if (ft0ceTrg) {
bcTH2Pointers[Form("bc/%d/ft0VtxCe_H", runNumberBc)]->Fill(thisTF, thisROF);
bcTH2Pointers[Form("bc/%d/ft0VtxCe_bcb_H", runNumberBc)]->Fill(thisTF, bcbIdx[thisBC]);
}
}
} // loop over bcs

Expand Down Expand Up @@ -671,7 +711,7 @@ struct UpcVmRof {
} // ZDC info

// fill output table
int recoFlag = (col.flags() & dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? 1 : 0;
int recoFlag = static_cast<int>((col.flags() & dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? true : false);

@vkucera vkucera Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. You are converting int -> bool on the left side of ? and converting bool -> int on the right side.
You can simply use TESTBIT(col.flags(), dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? 1 : 0.

@vkucera vkucera Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what do 1 and 0 mean?

@jgcn jgcn Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
thanks for the tip, and for the email explanations. I will try to follow as much as I can, and push again. I know that C++ is my tool and as such part of my job, but my real job is something else, so the learning curve for me takes a long time to travel ... I am trying, hopefully my learning will converge somewhen ... I will try to push this and whatever I understand from the email tomorrow. Thanks a lot for your help.
guillermo

if (selTrks.size() == NTrksTwoBody) {
colTH1Pointers[Form("col/%d/twoTrkTF_H", runNumberCol)]->Fill(thisTF);
twoTrkTable(runNumberCol, col.posX(), col.posY(), col.posZ(), col.chi2(), thisBC, thisTF, thisROF, recoFlag,
Expand Down
Loading