Skip to content

Prevent roamjs-components default import failures - #14

Merged
mdroidian merged 4 commits into
mainfrom
agent/prevent-roamjs-default-imports
Aug 21, 2026
Merged

Prevent roamjs-components default import failures#14
mdroidian merged 4 commits into
mainfrom
agent/prevent-roamjs-default-imports

Conversation

@mdroidian

Copy link
Copy Markdown
Member

Summary

  • document the ESM/CommonJS interop boundary for roamjs-components
  • reject default imports from published roamjs-components subpaths in both generated templates and prototype source
  • execute the generated production artifact through a lifecycle smoke test so interop failures are caught after bundling

Why

Published roamjs-components subpaths are TypeScript-compiled CommonJS. In this repository's ESM build, a default subpath import can resolve to a { default: fn } object instead of the callable export. Named exports from package barrels avoid that double-default boundary.

Validation

  • pnpm test
  • pnpm build
  • pnpm prepare:artifacts

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown

Roam prototype previews

CI passed, but this branch does not contain an installable prototype yet.

View publishing details

@mdroidian
mdroidian marked this pull request as ready for review August 21, 2026 04:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5215107343

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-prototypes.mjs Outdated

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread scripts/validate-prototypes.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d46f38833a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-prototypes.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a351cb5b15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-prototypes.mjs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 406e81e2ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/validate-prototypes.mjs
@mdroidian
mdroidian merged commit cd61b34 into main Aug 21, 2026
1 check passed
@mdroidian
mdroidian deleted the agent/prevent-roamjs-default-imports branch August 21, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant