log tbb header and library provenance during install#256
Merged
Conversation
Stale or unexpected TBB libraries swept into the installed package have been a subtle source of downstream load failures, and were invisible in installation logs. Report which headers and libraries are installed and from where, and note when the tbb stub build is skipped because a tbb.dll is already present. Additionally, when the VERBOSE environment variable is set (as already used by the bundled TBB build), report how TBB libraries are resolved and loaded at package load time; this would have surfaced the lookup bug fixed in #250 immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrospective from the 6.0.1 Windows debugging: several failure modes were invisible in logs and cost significant diagnosis time. This adds targeted logging at each of those blind spots:
.install.libs()reports which TBB libraries are installed and from where (** copying TBB libraries from 'tbb/build/lib_release' [tbb.dll, tbbmalloc.dll, ...]) -- the stale-artifact sweep fixed in use configure-detected TBB_LIB during install.libs #254/clean stale tbb build artifacts before shipping libraries #255 would have been visible in the very first install log.tbb.dllalready exists (the silent skip was the tell for the stale-artifact issue).useTbbPreamble()reports where the installed TBB headers come from (Rtools vs bundled -- the blind spot behind apply cpuid guard to tbb headers copied at install time #253).loadTbbLibrary()reports how TBB libraries are resolved and loaded at package load time, gated behind theVERBOSEenvironment variable already used by the bundled TBB build (kept quiet by default since this runs in.onLoad). This would have immediately surfaced the silent lookup failure fixed in fix lookup path for tbb stub library on windows #250.Install-time messages are always on, matching the existing
**/***style.