[server] Refine remote log manifest overlap handling - #3937
Merged
Conversation
Use physical manifest offsets where required, simplify RemoteLogTablet snapshot reads, and remove the obsolete incremental mutation helper. Keep overlap and timestamp lookup behavior covered by updated tests. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5.6-sol AI-Contributed/Feature: 112/112 AI-Contributed/UT: 130/130
wuchong
marked this pull request as ready for review
August 10, 2026 16:12
Member
Author
|
cc @gyang94 |
gyang94
reviewed
Aug 11, 2026
| for (RemoteLogSegment remoteLogSegment : remoteLogSegmentList) { | ||
| if (remoteLogSegment.logicalStartOffset() < startOffset) { | ||
| startOffset = remoteLogSegment.logicalStartOffset(); | ||
| if (remoteLogSegment.remoteLogStartOffset() < startOffset) { |
Contributor
There was a problem hiding this comment.
Sometimes the physical range is not equal to logical range. Use physical range may expose unavailable data to uers.
Assume:
- There is a remote manifest contains A:[0,10), B:[10,20)
- A expired, the manifest visible range is [10,20)
- leader switch, new physical segment is [5,25)
- After merge, there is only one segment should be with physical range [5,25), but logical range should be [10,25).
The hidden prefix [5,10) should not be readable again.
Member
Author
There was a problem hiding this comment.
Thank you @gyang94 , I think we can create a follow-up pull request to address this.
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up on the remote log overlap manifest handling introduced by #3822 and resolve the remaining implementation follow-ups.
Brief change log
Tests
./mvnw -pl fluss-common -DskipITs -Dfast -Dtest=RemoteLogManifestOverlapTest test(11 tests)./mvnw -pl fluss-server -am -DskipITs -Dfast -Dtest=RemoteLogTabletTest,RemoteLogTabletOverlapTest,DefaultRemoteLogStorageTest -Dsurefire.failIfNoSpecifiedTests=false test(22 tests)API and Format
Documentation
No user-facing documentation changes are required.
Generative AI disclosure