Set location in LaplaceCyclic::solve() and DC() - #1367
Merged
Conversation
Deprecated method for cross products now removed, but used in example on front page README. Now changed.
Changing README example to use cross rather than ^
bendudson
approved these changes
Nov 13, 2018
bendudson
left a comment
bendudson
left a comment
Contributor
There was a problem hiding this comment.
Yes, probably should also go into master. Thanks @johnomotani !
Member
|
@johnomotani I think there were a couple of extra fixes that made it into master than weren't in this PR? If so we should probably include those in next as well. (Sorry I think this was my fault, I hadn't noticed #1368 was into master and mirroring this PR). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, location of the result was not set in
LaplaceCyclic::solve(Field3D,Field3D)orDC(Field3D).This is a bug-fix - should it be merged to
masteras well?