Set location in LaplaceCyclic::solve() and DC() - #1368
Merged
Conversation
bendudson
previously approved these changes
Nov 13, 2018
d7919
reviewed
Nov 13, 2018
| x.setLocation(location); | ||
|
|
||
| Coordinates *coord = mesh->getCoordinates(); | ||
| Coordinates *coord = mesh->getCoordinates(location); |
Member
There was a problem hiding this comment.
A minor change but rhs.getCoordinates() might be preferred here.
Member
|
Are the other Laplacian implementations setting the location correctly? |
Neater than previous mesh->getCoordinates(location) calls.
Pass the location to delp2solver in LaplaceNaulin. Set location of result in solve() method of LaplaceXY, LaplaceXZcyclic and LaplaceXZpetsc.
d7919
approved these changes
Nov 14, 2018
Contributor
Author
Good point. Sorry I didn't check properly the first time around. There were indeed a few more places that location needed setting (see 7965a62). I guess this kind of issue is telling us we need more tests... sorry I don't have time to design them at the moment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge bugfix from #1367 to master also.