Remove uses of global 'mesh' from Laplacian solvers - #1371
Merged
Conversation
Neater than previous mesh->getCoordinates(location) calls.
Pass the location to delp2solver in LaplaceNaulin. Set location of result in solve() method of LaplaceXY, LaplaceXZcyclic and LaplaceXZpetsc.
johnomotani
force-pushed
the
Laplacian-localmesh-coords
branch
2 times, most recently
from
November 14, 2018 14:10
dd74771 to
3fc3fc5
Compare
Allow Laplacian solvers to be initialized with a local Mesh object, stored as Laplacian::localmesh. Use localmesh everywhere instead of global mesh, or mesh from Field*D.getMesh() to ensure consistency between initialization and solve methods. Includes ASSERT1 checks that 'localmesh == rhs.getMesh()', etc.
Always need the same Coordinates*, so call getCoordinates(location) once in constructor instead of in each call to solve().
johnomotani
force-pushed
the
Laplacian-localmesh-coords
branch
from
November 14, 2018 14:35
3fc3fc5 to
8c88783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also put the call to
getCoordinates(location)in theLaplacian::Laplacianconstructor and keep aCoordinates* coordspointer as a member ofLaplacianso we don't need to callgetCoordinates()in 15 other places in the various implementations.Pulls in to
nexta couple of extra commits from #1368; would it be better to make a separate PR for those?