Unify gh aw help/docs wording and expose experiments command in CLI reference#44794
gh aw help/docs wording and expose experiments command in CLI reference#44794Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
gh aw help/docs wording and expose experiments command in CLI reference
There was a problem hiding this comment.
Pull request overview
Aligns gh aw CLI help and documentation while making experiments discoverable.
Changes:
- Standardizes command, flag, and example wording.
- Exposes
experimentsin CLI help. - Updates documentation and help-text tests.
Show a summary per file
| File | Description |
|---|---|
cmd/gh-aw/main.go |
Clarifies compile and run help. |
docs/src/content/docs/setup/cli.md |
Aligns run and forecast examples. |
pkg/cli/add_command.go |
Documents URL support and scanner wording. |
pkg/cli/add_command_test.go |
Updates add help assertion. |
pkg/cli/add_wizard_command.go |
Standardizes scanner wording. |
pkg/cli/deploy_command.go |
Clarifies flags. |
pkg/cli/deploy_command_test.go |
Updates deploy assertion. |
pkg/cli/experiments_command.go |
Makes experiments visible. |
pkg/cli/experiments_command_test.go |
Tests command visibility. |
pkg/cli/fix_command.go |
Normalizes list punctuation. |
pkg/cli/forecast_command.go |
Aligns example workflow names. |
pkg/cli/lint_command.go |
Expands lint examples. |
pkg/cli/logs_command.go |
Clarifies limits and aliases. |
pkg/cli/logs_command_test.go |
Tests alias wording. |
pkg/cli/trial_command.go |
Clarifies trial help and flags. |
pkg/cli/update_command.go |
Clarifies update flag semantics. |
pkg/cli/update_command_test.go |
Updates scanner-help assertion. |
pkg/cli/upgrade_command.go |
Refines upgrade description. |
pkg/cli/validate_command.go |
Clarifies fail-fast behavior. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 19/19 changed files
- Comments generated: 2
- Review effort level: Medium
|
|
||
| `, validArtifactSets) + "\n\n" + WorkflowIDExplanation, |
| ` + string(constants.CLIExtensionPrefix) + ` lint --shellcheck --pyflakes`, | ||
| Example: ` ` + string(constants.CLIExtensionPrefix) + ` lint # Lint all .lock.yml workflows in the default directory | ||
| ` + string(constants.CLIExtensionPrefix) + ` lint .github/workflows/foo.lock.yml # Lint a specific lock file | ||
| ` + string(constants.CLIExtensionPrefix) + ` lint --dir .github/workflows # Lint all lock files in a custom directory |
|
✅ Test Quality Sentinel completed test quality analysis. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #44794 does not have the 'implementation' label and has only 46 new lines of code in business logic directories (threshold: 100). |
There was a problem hiding this comment.
The changes are purely help text, flag descriptions, and documentation consistency improvements. All updates look correct:
--no-security-scannerstandardized to "Skip ..." across all commandsexperimentscommand unhidden with matching test updatecompileexample corrected to proper positional-arg-before-flag orderlogsdate-filter comments now accurately reflect the default 10-run cap--dry-runwording aligned acrossrunandtrialforecastexample name changed todaily-news
No security, correctness, or reliability issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 17.5 AIC · ⌖ 7.38 AIC · ⊞ 4.8K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — one wording accuracy issue found; otherwise changes are clean and consistent.
📋 Key Themes & Highlights
Key Themes
- Consistency wins: Flag descriptions, examples, and the docs page are now aligned —
Disable→Skip,--watchargument order fixed,--lastalias clarified. experimentsvisibility: RemovingHidden: trueand the paired test update is a minimal, correct change. The docs section already existed, so no new docs are needed.- One accuracy concern:
trial --dry-rundescription changed from the accurate "without applying any changes" to "without triggering workflow runs", which undersells what the flag actually skips (repo creation + install, not just dispatch). See inline comment.
Positive Highlights
- ✅ Tests updated in lock-step with every flag description change
- ✅
--lastflag test added tologs_command_test.go— good regression coverage - ✅ Example argument order fix (
compile ci-doctor --watch) matches actual CLI parsing
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 32.1 AIC · ⌖ 4.42 AIC · ⊞ 6.6K
Comment /matt to run again
| cmd.Flags().Bool("force-delete-host-repo-before", false, "Force delete the host repository before creation if it already exists") | ||
| cmd.Flags().BoolP("yes", "y", false, "Skip confirmation prompts") | ||
| cmd.Flags().Bool("dry-run", false, "Preview trial execution without applying any changes") | ||
| cmd.Flags().Bool("dry-run", false, "Preview trial execution without triggering workflow runs") |
There was a problem hiding this comment.
[/grill-with-docs] The updated description "Preview trial execution without triggering workflow runs" may be too narrow — trial --dry-run also skips repo creation and workflow installation, not only the dispatch trigger. The prior wording "without applying any changes" was broader and more accurate.
Consider: "Preview trial execution without creating repos or running workflows"
@copilot please address this.
🧪 Test Quality Sentinel Report🔶 Test Quality Score: 46/100 — Needs improvement
📊 Metrics (5 modified test assertions)
|
There was a problem hiding this comment.
COMMENT — mostly solid wording improvements with one meaningful semantic issue.
Review themes
trial --dry-run description is semantically inaccurate
The new text "without triggering workflow runs" is potentially confusing: trial always triggers workflow runs by design (that is its purpose). The flag suppresses the actual dispatch, but the phrasing implies runs are optional, which muddies the command model. See inline comment.
Hardcoded default count in logs examples
Example comments now say "up to 10 runs" — this embeds the --count default inline, making examples brittle if the default changes. Non-blocking but fragile.
Rest of the changes
The --no-security-scanner → "Skip" wording, experiments unhiding, compile argument reordering, flag description clarifications, and test updates are all correct and well-scoped.
🔎 Code quality review by PR Code Quality Reviewer · 162.9 AIC · ⌖ 5 AIC · ⊞ 5.4K
Comment /review to run again
Comments that could not be inline-anchored
pkg/cli/trial_command.go:117
--dry-run description now contradicts trial behavior: the text "without triggering workflow runs" misrepresents what --dry-run skips.
<details>
<summary>💡 Details</summary>
The trial command exists specifically to trigger workflow runs in a temporary private repository. --dry-run skips the actual dispatch step — but saying "without triggering workflow runs" implies that triggering runs is trial's default behavior that --dry-run suppresses. That is correct in effect but re…
pkg/cli/logs_command.go:63
logs --start-date/--end-date example comments hardcode the default count: "Download up to 10 runs after date" embeds the --count default (10) directly in the help text.
<details>
<summary>💡 Details</summary>
If the default for --count/-c ever changes, these comments silently become wrong. The examples for --start-date -1w and --start-date -1w -c 5 already use the right phrasing by referencing the flag. Prefer referencing the flag behavior rather than inlining the default:
``…
pkg/cli/logs_command.go:254
--last described as an alias but has different zero-value semantics than --count/-c: calling it an "Alias for --count/-c" misleads users — --last 0 means "not set, defer to --count" while --count 0 means "download zero runs".
<details>
<summary>💡 Details</summary>
The two flags share similar intent but are NOT true aliases:
--count/-cdefault:10— "download 10 runs"--lastdefault:0— "not set; if > 0, override count"
So --last 0 and --count 0 behave completel…
pkg/cli/trial_command.go:288
--dry-run description omits that repo setup side effects still occur: "without triggering workflow runs" is incomplete — the trial command still creates/configures the temporary repository during dry-run, which is a significant side effect.
<details>
<summary>💡 Details</summary>
The trial command's dry-run stops workflow execution but still performs setup steps (e.g., ensureTrialRepository). The new description "Preview trial execution without triggering workflow runs" does not c…
pkg/cli/logs_command.go:239
Example comments hardcode "up to 10 runs" — will go stale if the default count changes: the default is currently 10, but embedding it as a literal in comment strings means future changes to the default will leave these comments silently wrong.
<details>
<summary>💡 Details</summary>
Four example comments were changed to say "up to 10 runs":
` + "`" + `logs --start-date 2024-01-01 # Download up to 10 runs after date` + "`" + `
` + "`" + `logs --end-date 2024-01-31 # Download…
</details>
PR Triage
Score breakdown: Impact 20 · Urgency 10 · Quality 18 CLI help-text/docs consistency fixes + makes
|
🤖 PR Triage Report
Rationale: Aligns CLI help/docs wording across
|
|
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed both unresolved review threads in commit 5865524:
Local validation ( |
|
@copilot please run the
|
Both review threads were already addressed in commit 5865524 from the previous pass. The branch is clean, up to date with CI re-trigger is still needed from a maintainer before merge. |
|
@copilot please run the
|
…cy-fixes Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Branch refreshed in commit |
|
@copilot please run the Unresolved review feedback to address:
Run: https://github.com/github/gh-aw/actions/runs/29130873851
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Fixed in commit |
This PR addresses the CLI consistency audit findings by aligning command help text, flag descriptions, and docs examples across
gh awcommands. It also resolves a high-impact docs mismatch by makingexperimentsdiscoverable from CLI help.CLI help consistency (wording, grammar, style)
add,deploy,update,upgrade,trial,run,logs,validate,lint, andfix.workflowspluralization, punctuation in numbered steps, example comment clarity).Flag description harmonization
--no-security-scannerwording to consistent “Skip …” language across relevant commands.--no-compilesemantics inupdate.--no-release-bumpbehavior inupdateexample text.logs --lasthelp text to explicitly reference--count/-c.Command discoverability and docs/CLI parity
experimentsvisible in CLI help output (previously hidden), matching documented command coverage.run --dry-runand forecast example naming consistency).Targeted test updates for help-text contracts