build: bump golangci-lint to v2.13.2, add make clean - #103
Merged
Conversation
v2.6.0's bundled type-checker can't read the export data Go 1.27 emits
("export data version 4 is greater than maximum supported version 2"),
which panics make lint outright now that Go 1.27 is the only toolchain
Homebrew has installed. v2.13.2 runs clean against the current codebase
with 0 new findings.
make clean removes bin/, dist/, completions/, and the stray ./markfluence
binary -- everything /.gitignore already treats as generated.
CI failed: v2.13.2's own go.mod requires go >= 1.26.0, but CI installs Go via go-version-file: go.mod, which reads this repo's "go 1.25" and gets 1.25.14 -- below that floor, so `go install` refused to build it at all (GOTOOLCHAIN=local, no auto-upgrade). That's a different failure than the one this branch set out to fix: locally, v2.6.0 couldn't *read* export data from a newer compiler; on CI, go1.25.14 compiles everything uniformly, so that mismatch never existed there in the first place -- only the go.mod floor did. v2.13.0 is the release where golangci-lint's minimum bumped from 1.25.0 to 1.26.0 (its own go.mod: "the minimum Go version must always be latest-1"). v2.12.2 is the newest release still on the 1.25.0 floor, and runs clean (0 issues) against this repo built with local Go 1.27.0 -- confirmed directly rather than assumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make lintpanics locally under Go 1.27 (the only toolchain Homebrew has now): golangci-lint v2.6.0's bundled analysis deps can't read the export data format the 1.27 compiler emits (export data version 4 is greater than maximum supported version 2).v2.12.2— the newest release still requiring onlygo 1.25.0(its own go.mod: "the minimum Go version must always be latest-1";v2.13.0bumped the floor togo >= 1.26.0, which broke CI'sgo-version-file: go.modinstall on the first push here, since CI reads this repo'sgo 1.25directive and gets 1.25.14). v2.12.2 runs clean (0 issues) built with local Go 1.27.0.make cleanrule to remove generated build artifacts (bin/,dist/,completions/, stray./markfluence) — everything.gitignorealready treats as generated but nothing previously removed in one step.Found while starting on
_plans/025/026's implementation on a separate branch; unrelated to that work, so splitting it out here.Test plan
make checkpasses clean end to end locally (vet, fmt-check, test, build, lint)make cleanremoves bin/, dist/, completions/, ./markfluence and nothing else