Skip to content

build: bump golangci-lint to v2.13.2, add make clean #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willkg merged 2 commits into from
Aug 28, 2026
+5 −2
Merged

build: bump golangci-lint to v2.13.2, add make clean #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffc37fe
build: bump golangci-lint to v2.13.2, add make clean
willkg Aug 28, 2026
ef15610
fix: pin golangci-lint to v2.12.2, not v2.13.2
willkg Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ $(LOCALBIN):
VERSION ?= dev
LDFLAGS = -ldflags "-X github.com/mozilla/markfluence/internal/buildinfo.Version=$(VERSION)"

GOLANGCI_LINT_VERSION ?= v2.6.0
GOLANGCI_LINT_VERSION ?= v2.12.2
GOLANGCI_LINT = $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)

COMPLETIONS_DIR ?= completions

.PHONY: help all build build-linux install completions lint vet fmt fmt-check test check regen-regressions
.PHONY: help all build build-linux install completions lint vet fmt fmt-check test check regen-regressions clean

help: ## Show this help
@echo "Available rules:"
Expand Down Expand Up @@ -69,6 +69,9 @@ check: ## Run every check CI runs, in CI's order -- the pre-flight before calli
regen-regressions: ## Regenerate the converter regression goldens
go test ./internal/convert -run TestRegression -update

clean: ## Remove build artifacts (bin/, dist/, completions/, ./markfluence)
rm -rf $(LOCALBIN) dist $(COMPLETIONS_DIR) markfluence

# golangci-lint (version/path defined near the top so `lint` can depend on it).
# Order-only dependency on $(LOCALBIN) so adding files to bin/ (e.g. `make
# build`) doesn't retrigger the install. Installs the versioned binary once.
Expand Down