OSAC-3530: Lock osac-csi-driver's branch via Terraform - #156
Merged
Conversation
osac-csi-driver is merging into osac (OSAC-3530). Locked its main branch read-only via lock_branch = true, matching the durable Terraform-managed pattern already established for fulfillment-service, osac-operator, and osac-aap (a one-off API-only lock reverts on the next auto-apply cycle since Terraform doesn't know about it).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesRepository archival configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eliorerz
enabled auto-merge (rebase)
August 1, 2026 20:11
eliorerz
disabled auto-merge
August 1, 2026 20:11
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osac-csi-driver is merging into osac (OSAC-3530, matching the fulfillment-service/osac-operator/osac-aap precedent). Set
lock_branch = trueon its module block so the lock is durable across Terraform's auto-apply cycles, rather than a one-off API call that silently reverts on the next apply (the exact failure mode already hit and fixed for the other three components).Also applied the same lock immediately via a direct API PUT (full GET-then-PUT preserving all other existing branch protection settings) so the repo is locked right now, not just once this PR merges.
Validation
tofu fmt -check -diff-- clean.tofu validate-- succeeds (only the same pre-existinghas_downloadsdeprecation warnings noted in prior PRs).Test plan
lock_branchchange on osac-csi-driver's branch protectionSummary by CodeRabbit