Faster DuplicateClassDeclarationRule#6038
Merged
Merged
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Jul 11, 2026
Comment on lines
-43
to
-46
| foreach ($allClasses as $reflectionClass) { | ||
| if ($reflectionClass->getName() !== $className) { | ||
| continue; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
before this PR, the rule iterated all reflected classes, for every class found while analysis.
after the PR we built a map once and than lookup said map so we don't need to iterate the possible big array of all reflected classes over and over.
VincentLanglet
approved these changes
Jul 11, 2026
staabm
referenced
this pull request
Jul 11, 2026
Each call swept every source locator, re-reading and re-parsing all stub files evicted from the parser cache. DuplicateClassDeclarationRule and DuplicateFunctionDeclarationRule call these for every class/function node during stub validation, causing ~4900 redundant file reads per process on phpstan-src self-analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired by 11aebc1
since DuplicateClassDeclarationRule is the only caller of
MemoizingReflector::reflectAllClasses, lets optimize the rule for its very specific use-case instead of memoizing only parts of the costs inMemoizingReflector.DuplicateFunctionDeclarationRulewill be optimized in a separate PR.before this PR:
after this PR: