Faster DuplicateFunctionDeclarationRule#6039
Merged
Merged
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
approved these changes
Jul 11, 2026
staabm
referenced
this pull request
Jul 11, 2026
Each call swept every source locator, re-reading and re-parsing all stub files evicted from the parser cache. DuplicateClassDeclarationRule and DuplicateFunctionDeclarationRule call these for every class/function node during stub validation, causing ~4900 redundant file reads per process on phpstan-src self-analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to #6038
the improvement is rather small because phpstan-src contains only few global functions.
in codebases with more functions it should safe even more. we also do this for consistency with
DuplicateClassDeclarationRulebefore the PR:
after the PR:
inspired by 11aebc1 which also memoizes
allConstants. this method has not a single caller in one of the phpstan/* repos, therefore we don't tackle it