Skip to content

Faster DuplicateFunctionDeclarationRule #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 3 commits into from
Jul 11, 2026
+20 −10
Merged

Faster DuplicateFunctionDeclarationRule #6039

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a5c94a
Faster DuplicateFunctionDeclarationRule
staabm Jul 11, 2026
5af2a91
cs
staabm Jul 11, 2026
0fec019
docs
staabm Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions src/Rules/Functions/DuplicateFunctionDeclarationRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
final class DuplicateFunctionDeclarationRule implements Rule
{

/** @var array<non-empty-string, list<ReflectionFunction>>|null */
private ?array $functionMap = null;

public function __construct(private Reflector $reflector, private RelativePathHelper $relativePathHelper)
{
}
Expand All @@ -35,25 +38,32 @@ public function getNodeType(): string
public function processNode(Node $node, Scope $scope): array
{
$thisFunction = $node->getFunctionReflection();
$allFunctions = $this->reflector->reflectAllFunctions();
$filteredFunctions = [];
foreach ($allFunctions as $reflectionFunction) {
if ($reflectionFunction->getName() !== $thisFunction->getName()) {
continue;
}
$functionName = $thisFunction->getName();

$filteredFunctions[] = $reflectionFunction;
// this rule runs at the very end of the analysis,
// so all function already have been discovered at this point.
if ($this->functionMap === null) {
$this->functionMap = [];

$allFunctions = $this->reflector->reflectAllFunctions();
foreach ($allFunctions as $reflectionFunction) {
$reflectionFunctionName = $reflectionFunction->getName();
if (!isset($this->functionMap[$reflectionFunctionName])) {
$this->functionMap[$reflectionFunctionName] = [];
}
$this->functionMap[$reflectionFunctionName][] = $reflectionFunction;
}
}

if (count($filteredFunctions) < 2) {
if (!isset($this->functionMap[$functionName]) || count($this->functionMap[$functionName]) < 2) {
return [];
}

return [
RuleErrorBuilder::message(sprintf(
"Function %s declared multiple times:\n%s",
$thisFunction->getName(),
implode("\n", array_map(fn (ReflectionFunction $function) => sprintf('- %s:%d', $this->relativePathHelper->getRelativePath($function->getFileName() ?? 'unknown'), $function->getStartLine()), $filteredFunctions)),
$functionName,
implode("\n", array_map(fn (ReflectionFunction $function) => sprintf('- %s:%d', $this->relativePathHelper->getRelativePath($function->getFileName() ?? 'unknown'), $function->getStartLine()), $this->functionMap[$functionName])),
))->identifier('function.duplicate')->build(),
];
}
Expand Down
Loading