Scan bytes as unsigned char in the implicit type matcher - #62
Merged
Conversation
The re2c scanner in implicit.c read bytes as signed char, so any byte >= 0x80 satisfied the end-of-token check (yych <= 0x00) and a UTF-8 string like "Noémie" matched the "No" boolean rule. #22 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syck.load("Noémie")returnsfalseandSyck.load("Yeså")returnstrue. The re2c scanner inimplicit.creads bytes as signedchar, so any byte >= 0x80 compares as negative and satisfies the end-of-token check (yych <= 0x00). A UTF-8 continuation byte then terminates the token early, andNoémiematches theNoboolean rule. ChangingYYCTYPEtounsigned charmakes only a real NUL end a token. All relational comparisons inimplicit.care these end-of-token checks, so the other implicit types are unaffected.implicit.reis not shipped in this repository, butYYCTYPEbelongs to its hand-written prologue, so the generated state machine is untouched.Fixes #22