Skip to content

Scan bytes as unsigned char in the implicit type matcher #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 1 commit into from
Jul 28, 2026
+13 −1
Merged

Scan bytes as unsigned char in the implicit type matcher #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/syck/implicit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "ruby/ruby.h"
#include "syck.h"

#define YYCTYPE char
#define YYCTYPE unsigned char
#define YYCURSOR cursor
#define YYMARKER marker
#define YYLIMIT limit
Expand Down
12 changes: 12 additions & 0 deletions test/test_boolean.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,17 @@ def test_n
assert_equal "n", Syck.load("--- n")
assert_equal "N", Syck.load("--- N")
end

###
# https://github.com/ruby/syck/issues/22
# A boolean-like prefix followed by a non-ASCII byte must not be
# matched as a boolean
def test_bool_prefix_with_non_ascii
assert_equal "Noémie", Syck.load("--- Noémie")
assert_equal ["Noémie"], Syck.load("--- [Noémie]")
assert_equal "Yeså", Syck.load("--- Yeså")
assert_equal "trueé", Syck.load("--- trueé")
assert_equal "nullé", Syck.load("--- nullé")
end
end
end