Use converted strings in query and fragment setters - #249
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use and copy the result of to_str in both query= and fragment=. The current code calls to_str but then continues invoking String methods on the original non-String receiver.
Reproduction
Give an Object a
to_strmethod returning'a b', and assign it to the query or fragment ofURI('https://example.test/a'). Before, delete! raises NoMethodError on the Object; after, the component is encoded like an ordinary String. Copying also protects a shared or frozen conversion result.Verification
bundle exec rake test: 93 tests / 3,039 assertions / zero failures or errors, both baseline and this isolated patch.git diff --checkpass. Supplemental Lint adds no findings against the 31-finding baseline.Compatibility and limitations
String-convertible values now work. Direct String and nil behavior is preserved; there is no new coercion through to_s. No public API removal, dependency change or Ruby minimum change.
Based on master
696df43b0be4c05d3a0dcf7db582126c915d860d. Other Ruby/OS runtimes were not executed locally. No production traffic or live mail/FTP services were used. Existing related PRs/issues were checked; this is a focused contribution, not exhaustive behavioral coverage.