Skip to content

Use converted strings in query and fragment setters #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −4
Open

Use converted strings in query and fragment setters #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bb5ce9
Use converted strings in query and fragment setters
OskarEichler Aug 27, 2026
4f787ec
test: cover URI regression
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/uri/generic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,7 @@ def query=(v)
return @query = nil unless v
raise InvalidURIError, "query conflicts with opaque" if @opaque

x = v.to_str
v = x.dup if x.equal? v
v = v.to_str.dup
v.encode!(Encoding::UTF_8) rescue nil
v.delete!("\t\r\n")
v.force_encoding(Encoding::ASCII_8BIT)
Expand Down Expand Up @@ -944,8 +943,7 @@ def opaque=(v)
def fragment=(v)
return @fragment = nil unless v

x = v.to_str
v = x.dup if x.equal? v
v = v.to_str.dup
v.encode!(Encoding::UTF_8) rescue nil
v.delete!("\t\r\n")
v.force_encoding(Encoding::ASCII_8BIT)
Expand Down
14 changes: 14 additions & 0 deletions test/uri/test_generic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,20 @@ def uri_to_ary(uri)
uri.class.component.collect {|c| uri.send(c)}
end


def test_query_and_fragment_use_to_str_result
converted = "a b".freeze
value = Object.new
value.define_singleton_method(:to_str) { converted }
uri = URI("https://example.test/path")

uri.query = value
uri.fragment = value

assert_equal("https://example.test/path?a%20b#a%20b", uri.to_s)
assert_equal("a b", converted)
end

def test_to_s
exp = 'http://example.com/'.freeze
str = URI(exp).to_s
Expand Down