Vectorize MsgItems

[Kestrellius]

Convert MsgItems from an array to a vector, and remove the associated limit value and counter.

MsgItems is dynamically rewritten at runtime, and previously used a counter value of -1 to indicate that the array was in a state suitable for rewriting in some circumstances. To replicate this behavior, MsgItems is now actually an std::optional<SCP_vector<mmode_item>>, and its nullopt state corresponds to -1.

[Goober5000]

This will need some rework. I sent a message on Discord

[Kestrellius]

There is an existing behavior where if you input a "comms menu move up" command in the same frame as opening the comms menu, you end up with a Selected_menu_item of -2, and the selection pointer isn't visible. You have to hit "move down" twice in order to get it to appear at the first entry, or "move up" once and it'll wrap around. At present this behavior is replicated faithfully in this branch, but alternatively I could fix this bug(?) by just early-returning out of the selection-movement commands if Rebuild_MsgItems is true. (Or if MsgItems.size() is 0?)

[wookieejedi]

I vote fixing the bug would be good, though you may also want to look at #7688. Possibly they could all be combined into one PR here?

[Goober5000]

I'd recommend, instead, fixing the bug in #7688 and keeping this PR focused on the vectorization. Then this PR can be rebased on 7688, after merge, and inherit or accommodate the fix.

[wookieejedi]

Ah yeah good point! Though I think merging this one first might work better, and then I can fully test all the cleanup and fixes in 7688 once this is merged :)

[wookieejedi]

@Goober5000 is this one good to merge now or is more review needed? Note, once this is merged I'll address various other fixes in 7688

[Goober5000]

@Goober5000 is this one good to merge now or is more review needed? Note, once this is merged I'll address various other fixes in 7688

No, there are several things that need to be addressed, but I haven't had time to respond. Will try to follow up ASAP.

[wookieejedi]

Thanks, sounds good!

[Goober5000]

It will be necessary to handle config mode, because MsgItems is only valid during a mission. So, in hudsquadmsg.cpp:

• Remove the active = -1 assignment, and enclosing if(), in HudGaugeSquadMessage::render
• Then, 22 lines later, add this before the if() and change the if() to use item_visible:

bool item_visible = config
    ? !(Hide_main_rearm_items_in_comms_gauge && (i == TYPE_REPAIR_REARM_ITEM || i == TYPE_REPAIR_REARM_ABORT_ITEM))
    : (MsgItems[First_menu_item + i].active >= 0);

[Goober5000]

Additional comments. With these changes, every ternary MsgItems ? sz2i(MsgItems.size()) : -1 can become just sz2i(MsgItems.size()).

[Goober5000]

This looks good now! One optional thing before merging.

[Goober5000]

This no longer needs to be in the header file. The declaration in the .cpp file can be made static.

[Kestrellius]

Done!