Expose SDP grammar converters for application-defined attributes - #512
Merged
Merged
Conversation
session_description already accepted custom attribute_converters, but the helper converters needed to build them were internal, and the lifetime of those converters relative to the returned grammar was undocumented. Declare the reusable converters and generators, document the by-reference capture and static-initialization constraints, and add a test that extends the default grammar with a=x-example-foo.
garethsb
force-pushed
the
feature/sdp-grammar-extensibility
branch
from
July 29, 2026 09:26
6c4b33e to
11d93c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session_descriptionalready accepted customattribute_converters, but the helper converters needed to build them were internal, and the lifetime of those converters relative to the returned grammar was undocumented. Declare the reusable converters and generators, document the by-reference capture and static-initialization constraints, and add a test that extends the default grammar witha=x-example-foo:<pt> <value>.Probable merge conflict with #505 - whichever is merged later will need rebasing.