Remove nono credential-isolation feature - #38
Merged
Merged
Conversation
nono was opt-in and default-off, but the product actively pushed it: gm-doctor WARNed on its absence and called it "strongly recommended," and the launch wizard nudged users to enable it. In practice it never delivered reliable value, so the recommendation pressure cost more than the feature returned. Strips it fully: - Delete nono-exec / nono-stub / nono-profile templates - Remove setup_nono() and NONO_* config handling from setup.sh; extract the still-needed ~/bin + ~/.local/bin PATH setup into a setup_path() helper (keeps ty + user tools on PATH, no nono coupling) - Drop NONO_* keys from config.example.env - Remove nono from README, gm-doctor (Check 9 + summary row), launch wizard, project-claude-md template, slack module docs - Keep the 2026-03-11 credential-proxy design docs as historical record No functional impact on executors: when nono was off (the default), agents already resolved claude/ty/gh/linear from PATH directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the nono credential-isolation feature from TaskYou-OS entirely.
Why
nono was opt-in and default-off, but the product actively pushed it:
gm-doctorCheck 9 reported WARN when nono was absent and called it "strongly recommended for all TaskYou deployments."launchwizard nudged users to enable it ("default to enabling it").In practice it never delivered reliable value. A "strongly recommended" feature that doesn't pay off is worse than neutral — it erodes trust in the doctor's other recommendations. Decision (Bruno): strip it out.
Safe to remove
nono was already inert when disabled (the default):
setup.shcleanly skipped every nono block, and agents resolvedclaude/ty/gh/linearstraight from PATH. Nothing (Linear, GitHub, Slack, R2) depends on it.Changes
templates/nono-exec.sh.tmpl,nono-stub.sh.tmpl,nono-profile.json.tmplsetup.sh— removesetup_nono(), theNONO_*defaults/proxy-flag generation, and bothNONO_ENABLEDcall sites. The still-needed~/bin+~/.local/binPATH setup (previously bundled with nono stub deployment) is extracted into a newsetup_path()helper called at both former sites — sotyand user tools stay on PATH with zero nono coupling.bash -npasses.config.example.env— dropNONO_ENABLED/NONO_CREDENTIALS/NONO_PROXY_HOSTSREADME.md— remove nono from the doctor-check list and feature list; reword the re-deploy note.claude/commands/gm-doctor.md— delete Check 9 + the summary-table row (Checks 1–8 unchanged).claude/commands/launch.md— remove the credential-isolation wizard steptemplates/project-claude-md.tmpl— remove the{{#NONO}}Credentials blockmodules/slack/README.md+docs/plans/2026-06-08-slack-module-design.md— drop "pair with nono" references2026-03-11credential-proxy design docs as historical recordVerification
nono/NONOgrep (excluding the kept design docs): no matchesbash -n setup.sh: OK🤖 Generated with Claude Code