Assert schedule is sorted properly - #38
Merged
Merged
Conversation
Bring in Tidepool LoopAlgorithm updates
The binary-search filterDateRange overload assumes its collection is sorted ascending by startDate, but returns silently-wrong results otherwise. Add a debug-only assert enforcing that contract (compiled out of release builds, so no runtime cost). This immediately surfaced an existing violation: testGlucoseEffectFromHistory built a `basal` schedule with segments out of order (and one with endDate before startDate, plus overlaps). Replace it with a well-formed sorted, contiguous, non-overlapping schedule, and regenerate the expected-effect fixture to match the corrected schedule.
Assert filterDateRange input is sorted ascending
ps2
changed the title
Camji55
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.