Skip to content

Assert schedule is sorted properly #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ps2 merged 4 commits into from
Jul 27, 2026
+114 −107
Merged

Assert schedule is sorted properly #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ca8566
Merge pull request #6 from tidepool-org/main
ps2 May 21, 2026
8faf496
Assert filterDateRange input is sorted ascending
ps2 May 24, 2026
2f5c630
Merge pull request #7 from LoopKit/harden/filterdaterange-sorted-assert
ps2 May 25, 2026
7d016fb
Merge branch 'main' into main
ps2 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sources/LoopAlgorithm/SampleValue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,13 @@ public extension Sequence where Element: TimelineValue {
public extension RandomAccessCollection where Element: TimelineValue, Index == Int {
func filterDateRange(_ startDate: Date?, _ endDate: Date?) -> [Element] {
guard !isEmpty else { return [] }
// This binary-search filter is only correct when the elements are sorted
// ascending by startDate. Catch contract violations in debug builds; the
// check is compiled out of release builds, so there is no runtime cost.
assert(
zip(self, dropFirst()).allSatisfy { $0.startDate <= $1.startDate },
"filterDateRange requires elements sorted ascending by startDate"
)
// Lower bound: first index where element.endDate >= startDate
var lo = startIndex
if let startDate {
Expand Down
Loading