Skip to content

vx_expression_clone, remove vx_file_write_array#8735

Merged
myrrc merged 1 commit into
developfrom
myrrc/ffi-cxx
Jul 13, 2026
Merged

vx_expression_clone, remove vx_file_write_array#8735
myrrc merged 1 commit into
developfrom
myrrc/ffi-cxx

Conversation

@myrrc

@myrrc myrrc commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Preparatory changes split from new C++ API PR.

  • Add vx_expression_clone
  • Remove accidental const modifier from vx_expression_not's output.
  • Fix a memory leak in vx_struct_fields_builder_add_field where a non-UTF8 field
    throws before DType was converted from a raw pointer to an Arc.
  • Make vx_array_sink_push return an error if array's dtype doesn't match sink's dtype.
  • Allow passing null pointers to FFI's free() functions.
  • Remove vx_file_write_array in favor of sink interface.

@myrrc myrrc requested a review from 0ax1 July 13, 2026 12:34
@myrrc myrrc added changelog/break A breaking API change lang/c Relates to the Vortex C (FFI) API labels Jul 13, 2026
@myrrc myrrc enabled auto-merge (squash) July 13, 2026 12:37
@myrrc myrrc mentioned this pull request Jul 13, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 18.17%

⚡ 3 improved benchmarks
✅ 1661 untouched benchmarks
⏩ 42 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 205.7 µs 168.8 µs +21.88%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 205.9 µs 169.5 µs +21.49%
Simulation eq_i64_constant 298.5 µs 267.8 µs +11.46%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/ffi-cxx (e784ed1) with develop (443b79b)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/cinclude/vortex.h Outdated
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/src/expression.rs
Comment thread vortex-ffi/Cargo.toml
@myrrc myrrc requested a review from 0ax1 July 13, 2026 15:00
@myrrc myrrc force-pushed the myrrc/ffi-cxx branch 2 times, most recently from 9a22bdb to a73dcea Compare July 13, 2026 15:08
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/cinclude/vortex.h Outdated
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc requested a review from 0ax1 July 13, 2026 15:45
@myrrc myrrc merged commit 3d78175 into develop Jul 13, 2026
78 checks passed
@myrrc myrrc deleted the myrrc/ffi-cxx branch July 13, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change lang/c Relates to the Vortex C (FFI) API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants